Revert "Remove deprecated service.py usages from test". For 29.x only #19434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 471ff77.
anandolee
requested review from
ericsalo and
mkruskal-google
and removed request for
a team
acozzette
approved these changes
Nov 27, 2024
shaod2
reviewed
Nov 27, 2024
|
This file is deleted in piper :P |
mkruskal-google
approved these changes
Nov 27, 2024
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
Clarification: This is deleted in main (for 30.x), but we're rolling this back for just the 29.x branch. |
hswong3i
added a commit
to alvistack/protocolbuffers-protobuf
that referenced
this pull request
Nov 28, 2024
git clean -xdf
git submodule sync --recursive
git submodule update --init --recursive
git submodule foreach git checkout -- .
tar zcvf ../protobuf_5.29.0.orig.tar.gz --exclude=.git .
debuild -uc -us
cp protobuf.spec ../protobuf_5.29.0-1.spec
cp ../*protobuf*5.29.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/protocolbuffers-protobuf-5.29.0/
cp _constraints /osc/home\:alvistack/protocolbuffers-protobuf-5.29.0/
rm -rf ../*proto*5.29.0*.*
See protocolbuffers#19434
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
added a commit
to alvistack/protocolbuffers-protobuf
that referenced
this pull request
Nov 28, 2024
git clean -xdf
git submodule sync --recursive
git submodule update --init --recursive
git submodule foreach git checkout -- .
tar zcvf ../protobuf_5.29.0.orig.tar.gz --exclude=.git .
debuild -uc -us
cp protobuf.spec ../protobuf_5.29.0-1.spec
cp ../*protobuf*5.29.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/protocolbuffers-protobuf-5.29.0/
cp _constraints /osc/home\:alvistack/protocolbuffers-protobuf-5.29.0/
rm -rf ../*proto*5.29.0*.*
See protocolbuffers#19434
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
added a commit
to alvistack/protocolbuffers-protobuf
that referenced
this pull request
Nov 28, 2024
git clean -xdf
git submodule sync --recursive
git submodule update --init --recursive
git submodule foreach git checkout -- .
tar zcvf ../protobuf_5.29.0.orig.tar.gz --exclude=.git .
debuild -uc -us
cp protobuf.spec ../protobuf_5.29.0-1.spec
cp ../*protobuf*5.29.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/protocolbuffers-protobuf-5.29.0/
cp _constraints /osc/home\:alvistack/protocolbuffers-protobuf-5.29.0/
rm -rf ../*proto*5.29.0*.*
See protocolbuffers#19434
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
added a commit
to alvistack/protocolbuffers-protobuf
that referenced
this pull request
Nov 29, 2024
git clean -xdf
git submodule sync --recursive
git submodule update --init --recursive
git submodule foreach git checkout -- .
tar zcvf ../protobuf_5.29.0.orig.tar.gz --exclude=.git .
debuild -uc -us
cp protobuf.spec ../protobuf_5.29.0-1.spec
cp ../*protobuf*5.29.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/protocolbuffers-protobuf-5.29.0/
cp _constraints /osc/home\:alvistack/protocolbuffers-protobuf-5.29.0/
rm -rf ../*proto*5.29.0*.*
See protocolbuffers#19434
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
jorenham
reviewed
Dec 4, 2024
| """ | ||
| raise NotImplementedError | ||
| raise NotImplementedError |
There was a problem hiding this comment.
This is causing the following fatal error in protobuf==5.29.0:
IndentationError: unindent does not match any outer indentation level (service.py, line 78)
hswong3i
added a commit
to alvistack/protocolbuffers-protobuf
that referenced
this pull request
Dec 5, 2024
git clean -xdf
git submodule sync --recursive
git submodule update --init --recursive
git submodule foreach git checkout -- .
tar zcvf ../protobuf_5.29.1.orig.tar.gz --exclude=.git .
debuild -uc -us
cp protobuf.spec ../protobuf_5.29.1-1.spec
cp ../*protobuf*5.29.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/protocolbuffers-protobuf-5.29.1/
cp _constraints /osc/home\:alvistack/protocolbuffers-protobuf-5.29.1/
rm -rf ../*proto*5.29.1*.*
See protocolbuffers#19434
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 471ff77.
Add the service test back and fix indent issue only for 29.x for #19430